On Thu, 8 Nov 2007 04:30:10 +0100 Adrian Bunk wrote: > On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote: > > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: > > > > > But on the other hand, it seems that only the ASIX code will work > > > > > right; the DM9601 and MCS7830 Kconfig is different/wrong. > > > > > > > > I'm not seeing the problem. > > > > > > > > Which configuration will be handled wrongly? > > > > > > Notice how only the ASIX kconfig depended on NET_ETHERNET... > > > since MII depends on NET_ETHERNET, and (last I knew) the > > > reverse dependencies didn't capture the complete dependency > > > tree, selecting only MII would leave out some stuff. > > > > Except for one s390 net driver (I'll check why it's doing this) the > > NET_ETHERNET option does not influence what code is being generated - > > it's just a Kconfig-internal option allowing to disable a huge bunch > > of drivers at once. > > Damn, I shouldn't have only grep'ed under drivers/. > > @davem: > > Please look at net/ipv4/arp.c:arp_process() > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or > CONFIG_NETDEV_10000=y will not be handled correctly there?
I'd say yes, you are correct. > And the best solution is to nuke all #ifdef's in this function and make > the code unconditionally available? --- ~Randy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
