From: Rick Jones <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 16:31:47 -0700
> Eric W. Biederman wrote: > > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > > > >>This patch fixes the following build error with CONFIG_SYSCTL=n: > >> > >><-- snip --> > >> > >>... > >>ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined! > >>ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined! > >>ERROR: "sysctl_rmem_max" [drivers/net/rrunner.ko] undefined! > >>make[2]: *** [__modpost] Error 1 > > > > > > I was going to ask if allowing drivers to increase rmem_max > > is something that we want to do. Apparently the road runner > > driver has been doing this since the 2.6.12-rc1 when the > > git repository starts so this probably isn't a latent bug. > > Although it does rather sound like a driver writer yanking the rope from the > hand's of the sysadmin and hanging him with it rather than letting the > sysadmin > do it himself. I've seen other drivers' README's suggesting larger mem's but > not their sources doing it. I really don't think what the roadrunner driver is doing is correct at all. I also think what DLM is doing is wrong too. If DLM really wants minimum, it can use SO_SNDBUFFORCE and SO_RCVBUFFORCE socket options and use whatever limits it likes. But even this is questionable. I'll put in Adrian's patch to fix the build as a first priority, but in the long term this cruft has gotta go. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
