From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Fri, 19 Oct 2007 13:00:52 +0400
> There's already such a helper to initialize this field.
> Use it.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Applied.
> /* reset queue_mapping to zero */
> - skb->queue_mapping = 0;
> + skb_set_queue_mapping(skb, 0);
This right here is a great example why I add next to no comments to
the code I write. They are %99.999 of the time stating the obvious,
and where a comment is needed it's the code's fault and the code in
such cases could be rewritten to make what's going on more clear thus
making any commentary, again, redundant and stating the obvious.
Here the case is the former, it's of the form:
/* Add one to 'a'! */
a += 1;
Gee thanks for letting me know! How insightful! :-))
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
