On Sun, Oct 14, 2007 at 08:20:37PM +0000, Guillaume Chazarain wrote: > > Just another data point, it seems that running the standard Bittorrent > client helps triggering the bug.
Doh! It was my patch a month ago which added code to update csum_start if the headroom changed that broke this. We'll need this patch for stable as well. [NET]: Fix csum_start update in pskb_expand_head I got confused by the dual nature of the off variable in the function pskb_expand_head. The csum_start offset should use nhead instead of off which can change depending on whether we are using offsets or pointers. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> However, the fact that you're triggering this code at all tells us that there is another bug further up the chain that's causing us to generate partial checksums even though the NIC doesn't support it. Can you please give me the output of ethtool -k <IFNAME> where <IFNAME> is the interface that TCP connection is going out of? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/net/core/skbuff.c b/net/core/skbuff.c index c3aa68c..70d9b5d 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -682,7 +682,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail, skb->transport_header += off; skb->network_header += off; skb->mac_header += off; - skb->csum_start += off; + skb->csum_start += nhead; skb->cloned = 0; skb->hdr_len = 0; skb->nohdr = 0; - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
