On Sun, 2007-10-14 at 16:15 -0700, Yinghai Lu wrote: > On 10/14/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > On Sun, 2007-10-14 at 09:15 +0200, Manfred Spraul wrote: > > > Yinghai Lu wrote: > > > > On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote: > > > > > > > >> Someone around with a MSI capable board? The forcedeth driver does > > > >> dev->irq = pci_dev->irq > > > >> in nv_probe(), especially before pci_enable_msi(). > > > >> Does pci_enable_msi() change pci_dev->irq? Then we would disable the > > > >> wrong interrupt.... > > > >> > > > > > > > > the request_irq==>setup_irq will make dev->irq = pci_dev->irq. > > > > > > > > > > > Where is that? > > > Otherwise I would propose the attached patch. My board is not > > > MSI-capable, thus I can't test it myself. > > > > Why not just copy pcidev->irq to dev->irq once ? > > it seems e1000 is using np->pci_dev->irq directly too.
Heh, allright, doesn't matter, I was just proposing to avoid one more indirection :-) Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
