From: David Miller <[EMAIL PROTECTED]>
Date: Thu, 11 Oct 2007 18:00:31 -0700 (PDT)
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 17:50:59 -0700
>
> > On Thu, 11 Oct 2007 17:40:26 -0700 (PDT)
> > David Miller <[EMAIL PROTECTED]> wrote:
> >
> > > From: Stephen Hemminger <[EMAIL PROTECTED]>
> > > Date: Thu, 11 Oct 2007 17:31:49 -0700
> > >
> > > > You don't need to re-read the status register and process the PHY irq's
> > > > inside loop.
> > > > Try this:
> > >
> > > Are you sure? What if a PHY interrupt comes in during the loop?
> >
> > The interrupt is level triggered, and will rearm.
>
> Fair enough.
Actually, your change isn't right for another reason.
You missed the necessary budget reducing logic that I used
in the original changes. You need to adjust work_limit
like this:
work_done += sky2_status_intr(hw, work_limit - work_done);
Otherwise if you just pass plain "work_limit", and we do loop, the
driver uses more quota than it really should.
And I've made that above correction to your patch in my tree.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
