On Tue, 2007-10-09 at 08:18 -0700, David Brownell wrote:
> > This patch makes the host RNDIS driver talk to RNDIS devices with an MTU
> > less than 1.5k, instead of refusing to talk to such a device.
> > Please apply.
> >
> > Signed-Off-by: Thomas Sailer <[EMAIL PROTECTED]>
>
> Acked-by: David Brownell <[EMAIL PROTECTED]>
>
> ... but patches in drivers/net go to netdev, not linux-usb-devel.
> And it'd be nice if the patch comment mentioned some particular
> device that's been observed to act this way.
Ok, next try.
The device in question is a low power radio device that speaks the
bpqether protocol over ethernet. bpqether frames are never longer than
320 bytes, so there is no need to support 1.5kbyte MTU in the device
firmware.
Tom
Signed-Off-by: Thomas Sailer <[EMAIL PROTECTED]>
--- 1/drivers/net/usb/rndis_host.c.orig 2007-09-04 17:51:11.000000000 +0200
+++ 2/drivers/net/usb/rndis_host.c 2007-09-04 17:54:26.000000000 +0200
@@ -512,11 +512,18 @@
}
tmp = le32_to_cpu(u.init_c->max_transfer_size);
if (tmp < dev->hard_mtu) {
- dev_err(&intf->dev,
- "dev can't take %u byte packets (max %u)\n",
- dev->hard_mtu, tmp);
- retval = -EINVAL;
- goto fail_and_release;
+ if (tmp <= net->hard_header_len) {
+ dev_warn(&intf->dev,
+ "dev can't take %u byte packets (max %u)\n",
+ net->hard_header_len+1, tmp);
+ retval = -EINVAL;
+ goto fail_and_release;
+ }
+ dev->hard_mtu = tmp;
+ net->mtu = dev->hard_mtu - net->hard_header_len;
+ dev_warn(&intf->dev,
+ "dev can't take %u byte packets (max %u), adjusting
MTU to %u\n",
+ dev->hard_mtu, tmp, net->mtu);
}
/* REVISIT: peripheral "alignment" request is ignored ... */
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
