Stephen Hemminger wrote:
Fix warnings from sparse checker about shadowed definition and improperly
formatted ethtool_strings.

I chose to change module parameter rather than uglify the code by changing
the variable name.

Changing the name of existing module parameters can potentially introduce breakage in the field.

Additionally, we have module_param_named() to account for this sort of thing, where the module parameter name differs from the internal variable name.

The rest looks OK.

Please resend, potentially moving the module parameter change(s) into a separate patch.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to