On Tue, Oct 02, 2007 at 02:11:38PM -0700, [EMAIL PROTECTED] wrote:
> From: Micah Gruber <[EMAIL PROTECTED]>
>
> This patch fixes an apparent potential null dereference bug where we
> dereference dev before a null check. This patch simply remvoes the
> can't-happen test for a null pointer.
>
> Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
> Cc: Grant Grundler <[EMAIL PROTECTED]>
Acked-by: Grant Grundler <[EMAIL PROTECTED]>
thanks!
grant
> Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
> Acked-by: Kyle McMartin <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> ---
>
> drivers/net/tulip/uli526x.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff -puN
> drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt
> drivers/net/tulip/uli526x.c
> ---
> a/drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt
> +++ a/drivers/net/tulip/uli526x.c
> @@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int
> unsigned long ioaddr = dev->base_addr;
> unsigned long flags;
>
> - if (!dev) {
> - ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
> - return IRQ_NONE;
> - }
> -
> spin_lock_irqsave(&db->lock, flags);
> outl(0, ioaddr + DCR7);
>
> _
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
