On Tue, Oct 02, 2007 at 03:02:56PM -0700, Michael Chan wrote: > On Tue, 2007-10-02 at 16:16 -0400, Andy Gospodarek wrote: > > Adding that flag in tg3_set_settings seemed like the most logical > > place > > since the driver works fine on boot. This is just an issue when > > re-enabling autonegotiation, so we should probably nip it there. > > > > Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> > > We also noticed this issue recently, but didn't pay too much attention > to it since it was more of a "cosmetic" issue. The driver behaves the > same since we rely on cmd->autoneg to decide whether to enable autoneg > or not. Your fix seems reasonable to me. Thanks. > > Acked-by: Michael Chan <[EMAIL PROTECTED]> >
I completely agree that it's cosmetic, it just seems like something decent to toss in there since it's the kind of thing others will start complaining about. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
