Corey Hickey wrote: > Patrick McHardy wrote: > >>> + nest = RTA_NEST_COMPAT(skb, TCA_OPTIONS, sizeof(opt), &opt); >>> + >>> + RTA_PUT_U32(skb, TCA_SFQ_QUANTUM, q->quantum); >>> + RTA_PUT_U32(skb, TCA_SFQ_PERTURB, q->perturb_period); >>> + RTA_PUT_U32(skb, TCA_SFQ_LIMIT, q->limit); >>> + RTA_PUT_U32(skb, TCA_SFQ_DIVISOR, q->hash_divisor); >>> + RTA_PUT_U32(skb, TCA_SFQ_FLOWS, q->depth); >>> RTA_PUT(skb, TCA_OPTIONS, sizeof(opt), &opt); >> >> >> >> This is wrong, RTA_NEST_COMPAT already dumps the structure. > > > You mean that last line (RTA_PUT) is superfluous, right?
Exactly. > Much thanks for the review. I'll make a new set of patches soon. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
