On Thu, 20 Sep 2007 17:46:01 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote: > > On Thu, 20 Sep 2007 16:51:13 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Stephen Hemminger wrote: > >>> Be more selective about when to enable the ram buffer watchdog code. > >>> It is unnecessary on XL A3 or later revs, and with Yukon FE > >>> the buffer is so small (4K) that the watchdog detects false positives. > >>> > >>> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > >> With all the sky2 patches flying about, it would be wise to include > >> notes like "applies to 2.6.23-rc" or "net-2.6.24" after the standard > >> "---" terminator. > >> > >> is this patch supposed to go on top of the sky2 patches that Linus just > >> pulled? > >> > >> > > It can go after previous 6 on both 2.6.23-rc and net-2.6.24 (with fuzz) > > Is it _needed_ in 2.6.23-rc, Mr. Maintainer? :) > > The answer to that question is not clear to me, given the description > and code. Yes, the patch is needed, because when tested on Yukon FE laptop, the 2.6.23-rc driver falsely thinks the receiver is stuck. Sorry, I didn't catch it sooner, but that is the one flavor of chip I don't have to test on. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html