Some comment from looking at the driver in the -mm tree:
- please kill the CPU_CHIP_SWAP macros and use the normal linux
cpu_to_le*/le*_to_cpu and verify them using sparse.
See Documentation/sparse.txt on how to do that
- please include the linux header in the .c file, not the .h
- please don't redefine the dma mask constants
- please use the firmware loader instead of mebedding a firmware
image
- please don't invent your own debugging macros but use
dev_dbg and friends
- please kill the ENTER/RET macros
- please kill BDX_ASSERT
- the unregister_netdev directly followed by free_netdev in
bdx_remove look buggy, but I'm not entirely sure how to handle
multi-port devices properly here.
- please declare bdx_ethtool_ops on file-scope and kill
bdx_ethtool_ops
- please don't put assignments into conditionals ala
if ((err = pci_request_regions(pdev, BDX_DRV_NAME)))
goto err_dma;
but rather write
err = pci_request_regions(pdev, BDX_DRV_NAME);
if (err)
goto err_dma;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
