From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 31 Aug 2007 17:09:04 +0800
> [PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value > > The function __pppoe_xmit modifies the skb data and therefore it needs > to copy and skb data if it's cloned. > > In fact, it currently allocates a new skb so that it can return 0 in > case of error without freeing the original skb. This is totally wrong > because returning zero is meant to indicate congestion whereupon pppoe > is supposed to wake up the upper layer once the congestion subsides. > > This makes sense for ppp_async and ppp_sync but is out-of-place for > pppoe. This patch makes it always return 1 and free the skb. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
