Cool. I'll try to see if I can clock my pc lower and run the experiments again. I'll measure cpu utilization also this time around. That should be useful for extrapolating.
Regards, Mandeep On 9/4/07, Daniele Venzano <[EMAIL PROTECTED]> wrote: > ----- Message d'origine ----- > De: Mandeep Singh Baines <[EMAIL PROTECTED]> > Date: Mon, 3 Sep 2007 20:20:36 -0700 > Sujet: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition > > >Hi Daniele, > > > >Attached is a patch for converting the sis900 driver to NAPI. Please take a > >look at let me know what you think. I'm not 100% sure if I'm handling the > >rotting packet issue correctly or that I have the locking right in > >tx_timeout. > >These might be areas to look at closely. > > > >I didn't see much saving in interrupts on my machine (too fast, I guess). But > >I still think its beneficial: pushing work out of the interrupt handler into > >a bottom half is a good thing and we no longer need to disable interrupts > >in start_xmit. > > > >I did see a significant boost to tx performance by optimizing start_xmit: > >more > >than double pps in pktgen. > > > >I'm also attaching some test results for various iterations of development. > > The patch looks good and I think it can be pushed higher (-mm ?) for some > wider > testing. I don't have the hardware available to do some tests myself, > unfortunately, but it would be similar to yours anyway. > > I'd like to know how this works for people with less memory and slower CPU, > but any > kind of test run will be appreciated. > > Thanks, bye. > > > -- > Daniele Venzano > [EMAIL PROTECTED] > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
