Am Freitag, 31. August 2007 schrieb Herbert Xu: > On Thu, Aug 30, 2007 at 09:51:31AM +0000, James Chapman wrote: > > > > The captured PPPoE stream seems to show incorrect data lengths in the > > PPPoE header for some captured PPPoE packets. The kernel's PPPoE > > datapath uses this length to extract the PPP frame and send it through > > to the ppp interface. Since your ppp stream is fine, the actual PPPoE > > header contents must be correct when it is parsed by the kernel PPPoE > > code. It seems more likely that this is a wireshark bug to me. > > If he were using the kernel pppoe driver, then this is because > PPP filtering is writing over a cloned skb without copying it. > > In fact, there seems to be quite a few bugs of this kind in > the various ppp*.c files. > > Please try the following patches to see if they make a > difference. > > I've audited ppp_generic.c and pppoe.c. I'll do pppol2tp > tomorrow. > > Cheers,
Herbert, your patches - applied against 2.6.23-rc4-g2d8348b4 - works like a charm :-) Among many other places at least http://bugzilla.kernel.org/show_bug.cgi?id=8409 but probably also http://bugzilla.kernel.org/show_bug.cgi?id=7938 are solved by your 7 patches. Many thanks -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
signature.asc
Description: This is a digitally signed message part.
