From: Joe Perches <[EMAIL PROTECTED]>
Date: Tue, 28 Aug 2007 14:12:00 -0700
> I've forward ported what I had.
>
> Option 1:
> DECLARE_MAC_BUF(var);
> printk(MAC_FMT, MAC_ARG(var, dev->dev_addr));
>
> perhaps it looks nicer to remove the MAC_FMT and defines.
>
> Option 2:
> DECLARE_MAC_BUF(mac);
> printk("%s", print_mac(mac, dev->dev_addr));
>
> Option 3:
> char mac[PRINT_MAC_SIZE];
> printk("%s", print_mac(mac, dev->dev_addr));
>
> Option 4:
> char mac[18];
> printk("%s", print_mac(mac, dev->dev_addr));
>
> Preferences?
The less details exposed to the user the better, and in this sense
options 1 and 2 are the clear winners as far as I can tell.
Between them, 1 and 2 seem roughly the same, but I'm slightly leaning
towards 2.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
