From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:10 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > Leave out the one in reiserfs_fs.h as it is in the userspace-visible part > of that header. Still, #undef the (equivalent) kernel version there to > avoid seeing "redefined, previous definition was here" gcc warnings. > > [EMAIL PROTECTED]: fix U16_MAX, U32_MAX defns] > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
I won't apply this one, for two reasons: 1) The reiserfs definition is better, it is _type_ based. Please use (~(__u16)0) and (~(__u32)0), respectively. 2) The reiserfs definition is going to define an equivalent value, so just adding an #undef and still letting reiserfs override is wrong. Why put a common define in kernel.h if other headers still keep their own crufty copy too? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
