From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:03 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > Presently, boot/module parameters are set up quite differently for the case of > built-in netconsole (__setup() -> obsolete_checksetup() -> > netpoll_parse_options() -> strlen(config) == 0 in init_netconsole()) vs > modular netconsole (module_param_string() -> string copied to the config > variable -> strlen(config) != 0 init_netconsole() -> netpoll_parse_options()). > > This patch makes both of them similar by doing exactly the equivalent of a > module_param_string() in option_setup() also -- just copying the param string > passed from the kernel command line into "config" variable. So, > strlen(config) != 0 in both cases, and netpoll_parse_options() is always > called from init_netconsole(), thus making the setup logic for both cases > similar. > > Now, option_setup() is only ever called / used for the built-in case, so we > put it inside a #ifndef MODULE, otherwise gcc will complain about > option_setup() being "defined but not used". Also, the "configured" variable > is redundant with this patch and hence removed. > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> > Acked-by: Matt Mackall <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Applied to net-2.6.24, thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
