> +static struct ib_mw *nes_alloc_mw(struct ib_pd *ibpd) { > + get_random_bytes(&next_stag_index, sizeof(next_stag_index));
Could this use up a lot of entropy? Is random32() sufficient? > + stag_key = (u8)next_stag_index; I don't think this cast is needed. > + if (ret) { > + return (ERR_PTR(ret)); > + } Don't need braces for one-line blocks. > + if (NULL == cqp_request) { It's more idiomatic to write "if (!cqp_request) {" - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html