From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sat, 21 Jul 2007 07:46:39 +0200
> I believe the compat attribute should work fine. One thing thing > that is not explicitly supported as datatype, but works fine, is > lists of attributes (using nla_for_each_attr), which looks like a > good match for this case. But I think its questionable whether we > should put any effort in NAPI rtnetlink support. It seems to driver > specific for rtnetlink to me, and I'm not aware of any user of this. > Ethtool might have its own compatibility issues, I'm not sure, but > I don't think it would hurt to simply remove it from rtnetlink. Another idea is to allow the driver to decide what to do with the value. The driver will have to be involved anyways in order to iterate over the per-netdev NAPI objects. So, for example, one driver might take the given weight and distribute it evenly amongst the RX queues it has. Trying to let netlink set things on a per-queue basis is indeed cumbersom and not worth doing at all in my opinion. I however think it's not a bad idea to keep the unary weight setting around and let the driver figure out what to do with it in the multi-queue case. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
