ext Brian King wrote:
> Ragner Magalhaes wrote:
>> ext Brian King wrote:
>>
>>> +
>>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>>> +{
>>> + struct ibmveth_adapter *adapter = dev->priv;
>>> +
>> Why do not to do
>>
>> if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
>> return 0;
>> less two lines.
>
> Ok.
>
>> here also, as above ...
>>> + if (data && (dev->features & NETIF_F_IP_CSUM))
>>> + return 0;
>>> + if (!data && !(dev->features & NETIF_F_IP_CSUM))
>>> + return 0;
>
> This change would make the line > 80 columns, which I prefer to avoid.
> Updated patch attached which addresses the first comment.
I think would not be ugly to make.
if ((data && (dev->features & NETIF_F_IP_CSUM)) ||
(!data && !(dev->features & NETIF_F_IP_CSUM)))
return 0;
>
> Thanks,
>
> Brian
>
> ---
Thanks,
Ragner
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
