From: Ranko Zivojnovic <[EMAIL PROTECTED]> Date: Mon, 16 Jul 2007 20:45:05 +0300
> [NET] gen_estimator deadlock fix > > -Fixes ABBA deadlock noted by Patrick McHardy <[EMAIL PROTECTED]>: > > > There is at least one ABBA deadlock, est_timer() does: > > read_lock(&est_lock) > > spin_lock(e->stats_lock) (which is dev->queue_lock) > > > > and qdisc_destroy calls htb_destroy under dev->queue_lock, which > > calls htb_destroy_class, then gen_kill_estimator and this > > write_locks est_lock. > > To fix the ABBA deadlock the rate estimators are now kept on an rcu list. > > -The est_lock changes the use from protecting the list to protecting > the update to the 'bstat' pointer in order to avoid NULL dereferencing. > > -The 'interval' member of the gen_estimator structure removed as it is > not needed. > > Signed-off-by: Ranko Zivojnovic <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
