Veena Parat <[EMAIL PROTECTED]> :
> Implementation of review comments
> - Incorporated Jeff Garzik's comments on coding standards
> - Incorporated Andreas Schwab's comments on redundant condition check
>
> Signed-off-by: Veena Parat <[EMAIL PROTECTED]>
[...]
> diff -Nurp 2.0.23.1P3/drivers/net/s2io.h 2.0.23.1P4/drivers/net/s2io.h
> --- 2.0.23.1P3/drivers/net/s2io.h 2007-07-03 23:58:40.000000000 -0700
> +++ 2.0.23.1P4/drivers/net/s2io.h 2007-07-04 02:54:29.000000000 -0700
> @@ -464,7 +464,7 @@ struct TxD {
> #define TXD_LIST_OWN_XENA BIT(7)
> #define TXD_T_CODE (BIT(12)|BIT(13)|BIT(14)|BIT(15))
> #define TXD_T_CODE_OK(val) (|(val & TXD_T_CODE))
> -#define GET_TXD_T_CODE(val) ((val & TXD_T_CODE)<<12)
> +#define GET_TXD_T_CODE(val) ((val & TXD_T_CODE)>> 48)
> #define TXD_GATHER_CODE (BIT(22) | BIT(23))
> #define TXD_GATHER_CODE_FIRST BIT(22)
> #define TXD_GATHER_CODE_LAST BIT(23)
> @@ -503,6 +503,7 @@ struct RxD_t {
> u64 Control_1;
> #define RXD_OWN_XENA BIT(7)
> #define RXD_T_CODE (BIT(12)|BIT(13)|BIT(14)|BIT(15))
> +#define GET_RXD_T_CODE(val) ((val & RXD_T_CODE) >> 48)
> #define RXD_FRAME_PROTO vBIT(0xFFFF,24,8)
> #define RXD_FRAME_PROTO_IPV4 BIT(27)
> #define RXD_FRAME_PROTO_IPV6 BIT(28)
I must be more dense than usual tonight but it does not seem related to
the description of the patch.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
