On Wed, Jun 10, 2026 at 16:12:37 -0700, Bobby Eshleman wrote: > It looks like vmci might be an odd duck here, where sk_acceptq_added > actually pairs with vsock_add_pending(), instead of > vsock_enqueue_accept()... > > For example, if the pending work timer below fires, vsock_pending_work() > will see vsock_is_pending() is true, and then hit sk_acceptq_removed() > and underflow the zero backlog counter?
You're right, thank you for catching that. In vmci sk_acceptq_added() pairs with vsock_add_pending(), not vsock_enqueue_accept(), so moving it would cause an underflow when the pending work timer fires without a successful connection. Patch 2/2 is unaffected. I'll send a v2 that keeps the vmci call site as-is and only folds the virtio and hyperv sites into vsock_enqueue_accept(). Raf
