On 11/26/25 5:31 PM, Michael S. Tsirkin wrote:
> On Wed, Nov 26, 2025 at 01:35:32PM -0600, Daniel Jurgens wrote:
>> @@ -5812,6 +6019,17 @@ static int virtnet_restore_up(struct virtio_device
>> *vdev)
>> return err;
>> }
>>
>> + /* Initialize flow filters. Not supported is an acceptable and common
>> + * return code
>> + */
>> + rtnl_lock();
>> + err = virtnet_ff_init(&vi->ff, vi->vdev);
>> + if (err && err != -EOPNOTSUPP) {
>> + rtnl_unlock();
>> + return err;
>
> does not look like this rolls back previous
> initialization on error (probe does).
>
Thanks, I'll address it.
Have you reviewed the others? I'll wait until Wednesday morning to
resend, unless you confirm that's the only comment.