Re: [PATCH net-next v12 09/12] virtio_net: Implement IPv4 ethtool flow rules

[Dan Jurgens]

On 11/24/25 3:51 PM, Michael S. Tsirkin wrote:
> On Wed, Nov 19, 2025 at 01:15:20PM -0600, Daniel Jurgens wrote:
>> Add support for IP_USER type rules from ethtool.
>>
>> Example:
>> $ ethtool -U ens9 flow-type ip4 src-ip 192.168.51.101 action -1
>> Added rule with ID 1
>>
>> The example rule will drop packets with the source IP specified.
>>
>> Signed-off-by: Daniel Jurgens <dani...@nvidia.com>
>> Reviewed-by: Parav Pandit <pa...@nvidia.com>
>> Reviewed-by: Shahar Shitrit <shshit...@nvidia.com>
>> Reviewed-by: Xuan Zhuo <xuanz...@linux.alibaba.com>
>> ---
>> v4:
>>     - Fixed bug in protocol check of parse_ip4
>>     - (u8 *) to (void *) casting.
>>     - Alignment issues.
>>
>> v12
>>     - refactor calculate_flow_sizes to remove goto. MST
>>     - refactor build_and_insert to remove goto validate. MST
>>     - Move parse_ip4 l3_mask check to TCP/UDP patch. MST
>>     - Check saddr/daddr mask before copying in parse_ip4. MST
>>     - Remove tos check in setup_ip_key_mask.
> 
> So if user attempts to set a filter by tos now, what blocks it?
> because parse_ip4 seems to ignore it ...
> 
Added it to validate_ipv4_mask.