On 11/18/25 1:01 PM, Michael S. Tsirkin wrote: > On Tue, Nov 18, 2025 at 08:38:57AM -0600, Daniel Jurgens wrote: >> Filtering a flow requires a classifier to match the packets, and a rule
>> + size_t key_size) >> + ff_rule->group_id = cpu_to_le32(VIRTNET_FF_ETHTOOL_GROUP_PRIORITY); >> + ff_rule->classifier_id = cpu_to_le32(classifier_id); >> + ff_rule->key_length = (u8)key_size; > > I don't think you need this cast. > > BTW why do you insist on making all this math in size_t variables? > > Just u8 should do, and in calculate_flow_sizes you can do a BUG_ON to check > it does not overflow. > Ok
