On 11/18/25 5:03 PM, Michael S. Tsirkin wrote: > On Tue, Nov 18, 2025 at 08:38:55AM -0600, Daniel Jurgens wrote: >> diff --git a/include/uapi/linux/virtio_net_ff.h >> b/include/uapi/linux/virtio_net_ff.h >> new file mode 100644 >> index 000000000000..bd7a194a9959 >> --- /dev/null >> +++ b/include/uapi/linux/virtio_net_ff.h >> @@ -0,0 +1,91 @@ >> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note >> + * >> + * Header file for virtio_net flow filters >> + */ >> +#ifndef _LINUX_VIRTIO_NET_FF_H >> +#define _LINUX_VIRTIO_NET_FF_H >> + >> +#include <linux/types.h> >> +#include <linux/kernel.h> > > > I do not get why you are pulling linux/kernel.h here. > > include/uapi/linux/virtio_pci.h does it too, > and I think it's also a bug. > > No other uapi header does this, it happens not to break userspace > because userspace puts a completely unrelated header at > the same path - uapi/linux/kernel.h . >
Removed it. Previously I had added the FF definitions to virtio_pci.h, I guess I kept that include when I split this out.
