On Mon, Dec 30, 2024 at 5:51 PM Chia-Yu Chang (Nokia) <[email protected]> wrote: > > >From: Jason Wang <[email protected]> > >Sent: Monday, December 30, 2024 8:52 AM > >To: Chia-Yu Chang (Nokia) <[email protected]> > >Cc: [email protected]; [email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; > >[email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; > >[email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; Koen > >De Schepper (Nokia) <[email protected]>; > >[email protected]; [email protected]; > >[email protected]; [email protected]; [email protected]; > >[email protected]; [email protected] > >Subject: Re: [PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in > >virtio_net_hdr > > > >[You don't often get email from [email protected]. Learn why this is > >important at https://aka.ms/LearnAboutSenderIdentification ] > > > >CAUTION: This is an external email. Please be very careful when clicking > >links or opening attachments. See the URL nok.it/ext for additional > >information. > > > > > > > >On Sat, Dec 28, 2024 at 3:13 AM <[email protected]> wrote: > >> > >> From: Chia-Yu Chang <[email protected]> > >> > >> Unlike RFC 3168 ECN, accurate ECN uses the CWR flag as part of the ACE > >> field to count new packets with CE mark; however, it will be corrupted > >> by the RFC 3168 ECN-aware TSO. Therefore, fallback shall be applied by > >> seting NETIF_F_GSO_ACCECN to ensure that the CWR flag should not be > >> changed within a super-skb. > >> > >> To apply the aforementieond new AccECN GSO for virtio, new featue bits > >> for host and guest are added for feature negotiation between driver > >> and device. And the translation of Accurate ECN GSO flag between > >> virtio_net_hdr and skb header for NETIF_F_GSO_ACCECN is also added to > >> avoid CWR flag corruption due to RFC3168 ECN TSO. > >> > >> Signed-off-by: Chia-Yu Chang <[email protected]> > >> --- > >> drivers/net/virtio_net.c | 14 +++++++++++--- > >> drivers/vdpa/pds/debugfs.c | 6 ++++++ > >> include/linux/virtio_net.h | 16 ++++++++++------ > >> include/uapi/linux/virtio_net.h | 5 +++++ > >> 4 files changed, 32 insertions(+), 9 deletions(-) > > > >Is there a link to the spec patch? It needs to be accepted first. > > > >Thanks > > Hi Jason, > > Thanks for the feedback, I found the virtio-spec in github: > https://github.com/oasis-tcs/virtio-spec but not able to find the procedure > to propose. > Could you help to share the procedure to propose spec patch? Thanks.
Sorry for the late reply. You can start by subscribing to virtio-dev and send a spec patch there. Thanks > > -- > Chia-Yu
