> From: PJ Waskiewicz <[EMAIL PROTECTED]> > Date: Mon, 18 Jun 2007 11:42:29 -0700 > > > + > > + /* The TX queue control structures */ > > + struct net_device_subqueue *egress_subqueue; > > + int egress_subqueue_count; > > Since every net device will have at least one subqueue, I > would suggest that you do this as follows: > > 1) In net_device change the quoted part of the patch above to: > > int egress_subqueue_count; > struct net_device_subqueue egress_subqueue[0]; > > 2) In alloc_netdev(): > > Factor (sizeof(struct egress_subqueue) * num_subqueues) into > the net_device allocation size, place the "priv" area after > the subqueues. > > This will save us pointer dereferences on all of these quite > common accesses.
Thanks Dave! I'll be putting this in today and run a test pass on it. Thanks for the feedback. -PJ Waskiewicz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
