On Fri, Apr 16, 2021 at 05:11:46PM +0200, Sabrina Dubroca wrote:
> While testing ipcomp on a realtime kernel, Xiumei reported a "sleeping
> in atomic" bug, caused by a memory allocation while preemption is
> disabled (ipcomp_decompress -> alloc_page -> ... get_page_from_freelist).
> 
> As Sebastian noted [1], this get_cpu() isn't actually needed, since
> ipcomp_decompress() is called in napi context anyway, so BH is already
> disabled.
> 
> This patch replaces get_cpu + per_cpu_ptr with this_cpu_ptr, then
> simplifies the error returns, since there isn't any common operation
> left.
> 
> [1] 
> https://lore.kernel.org/lkml/[email protected]/
> 
> Cc: Juri Lelli <[email protected]>
> Reported-by: Xiumei Mu <[email protected]>
> Suggested-by: Sebastian Andrzej Siewior <[email protected]>
> Signed-off-by: Sabrina Dubroca <[email protected]>

Applied, thanks a lot!

Reply via email to