> -----Original Message----- > From: Richard Cochran <[email protected]> > Sent: 2021年4月18日 23:11 > To: Vladimir Oltean <[email protected]> > Cc: Y.b. Lu <[email protected]>; [email protected]; Vladimir Oltean > <[email protected]>; David S . Miller <[email protected]>; Jakub > Kicinski <[email protected]>; Jonathan Corbet <[email protected]>; Kurt > Kanzenbach <[email protected]>; Andrew Lunn <[email protected]>; Vivien > Didelot <[email protected]>; Florian Fainelli <[email protected]>; > Claudiu Manoil <[email protected]>; Alexandre Belloni > <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling > > On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimir Oltean wrote: > > > > How about not passing "clone" back to DSA as an argument by reference, > > but instead require the driver to populate DSA_SKB_CB(skb)->clone if > > it needs to do so? > > > > Also, how about changing the return type to void? Returning true or > > false makes no difference.
Thank you. That's good idea. And how about letting driver store the skb clone pointer, or not? I copied my comments in patch #3 here, " Can we totally drop dsa_skb_cb in dsa core? The only usage of it is holding a skb clone pointer, for only felix and sja1105. Actually we can move such pointer in <device>_skb_cb, instead of reserving the space of skb for any drivers." > > +1 > > Thanks, > Richard
