> * Miklos Szeredi <[EMAIL PROTECTED]> 2007-06-18 11:44
> > Garbage collection only ever happens, if the app is sending AF_UNIX
> > sockets over AF_UNIX sockets. Which is a rather rare case. And which
> > is basically why this bug went unnoticed for so long.
> >
> > So my second patch only affects the performance of _exactly_ those
> > apps which might well be bitten by the bug itself.
>
> That's not entirely the truth. It affects all applications using
> AF_UNIX sockets while file descriptors are being transfered. I
> agree that the performance impact is not severe on most systems
> but if file descriptors are being transfered continously by just
> a single application it can become rather severe.
You are wrong. Look in unix_release_sock():
if (atomic_read(&unix_tot_inflight))
unix_gc(); /* Garbage collect fds */
unix_tot_inflight is the number of AF_UNIX sockets currently being
transferred over some AF_UNIX sockets.
That means that just sending (non-unix socket) fds over unix sockets
will never invoke the gc.
Miklos
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
