> #define MII_88E6390_MISC_TEST_TEMP_SENSOR_ENABLE_ONESHOT (0x2 << 14)
> #define MII_88E6390_MISC_TEST_TEMP_SENSOR_DISABLE (0x3 << 14)
> #define MII_88E6390_MISC_TEST_TEMP_SENSOR_MASK (0x3 <<
> 14)
> +#define MII_88E6393_MISC_TEST_SAMPLES_4096 0x0000
> +#define MII_88E6393_MISC_TEST_SAMPLES_8192 0x0800
> +#define MII_88E6393_MISC_TEST_SAMPLES_16384 0x1000
> +#define MII_88E6393_MISC_TEST_SAMPLES_32768 0x1800
> +#define MII_88E6393_MISC_TEST_SAMPLES_MASK 0x1800
Please represent these as (0x0 << 11), (0x1 << 11) etc. It makes it
easier to map it back to the datasheet which always talks about values
in bit fields, now the complete word.
> +#define MII_88E6393_MISC_TEST_RATE_2_3MS 0x0500
> +#define MII_88E6393_MISC_TEST_RATE_6_4MS 0x0600
> +#define MII_88E6393_MISC_TEST_RATE_11_9MS 0x0700
> +#define MII_88E6393_MISC_TEST_RATE_MASK 0x0700
Same here.
Andrew
