On Mon, Apr 12, 2021 at 11:26:35AM +0300, Roi Dayan wrote:
>
>
> On 2021-04-11 1:58 PM, Pablo Neira Ayuso wrote:
> > Hi Roi,
> >
> > On Sun, Apr 11, 2021 at 11:13:34AM +0300, Roi Dayan wrote:
> > > It could be dst_cache was not set so check it's not null before using
> > > it.
> >
> > Could you give a try to this fix?
> >
> > net/sched/act_ct.c leaves the xmit_type as FLOW_OFFLOAD_XMIT_UNSPEC
> > since it does not cache a route.
> >
> > Thanks.
> >
>
> what do you mean? FLOW_OFFLOAD_XMIT_UNSPEC doesn't exists so default 0
> is set.
>
> do you suggest adding that enum option as 0?
Yes. This could be FLOW_OFFLOAD_XMIT_TC instead if you prefer.
enum flow_offload_xmit_type {
FLOW_OFFLOAD_XMIT_TC = 0,
FLOW_OFFLOAD_XMIT_NEIGH,
FLOW_OFFLOAD_XMIT_XFRM,
FLOW_OFFLOAD_XMIT_DIRECT,
};
so there is no need to check for no route in the
FLOW_OFFLOAD_XMIT_NEIGH case (it's assumed this type always has a
route).
