Hi Lorenzo,
On Thu, Apr 08, 2021 at 02:50:54PM +0200, Lorenzo Bianconi wrote:
> Introduce xdp_shared_info data structure to contain info about
> "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info
> allowing to keep most of the frags in the same cache-line.
> Introduce some xdp_shared_info helpers aligned to skb_frag* ones
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> ---
Would you mind updating all drivers that use skb_shared_info, such as
enetc, and not just mvneta? At the moment I get some build warnings:
drivers/net/ethernet/freescale/enetc/enetc.c: In function
‘enetc_xdp_frame_to_xdp_tx_swbd’:
drivers/net/ethernet/freescale/enetc/enetc.c:888:9: error: assignment to
‘struct skb_shared_info *’ from incompatible pointer type ‘struct
xdp_shared_info *’ [-Werror=incompatible-pointer-types]
888 | shinfo = xdp_get_shared_info_from_frame(xdp_frame);
| ^
drivers/net/ethernet/freescale/enetc/enetc.c: In function
‘enetc_map_rx_buff_to_xdp’:
drivers/net/ethernet/freescale/enetc/enetc.c:975:9: error: assignment to
‘struct skb_shared_info *’ from incompatible pointer type ‘struct
xdp_shared_info *’ [-Werror=incompatible-pointer-types]
975 | shinfo = xdp_get_shared_info_from_buff(xdp_buff);
| ^
drivers/net/ethernet/freescale/enetc/enetc.c: In function
‘enetc_add_rx_buff_to_xdp’:
drivers/net/ethernet/freescale/enetc/enetc.c:982:35: error: initialization of
‘struct skb_shared_info *’ from incompatible pointer type ‘struct
xdp_shared_info *’ [-Werror=incompatible-pointer-types]
982 | struct skb_shared_info *shinfo =
xdp_get_shared_info_from_buff(xdp_buff);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
