Hi Ioana, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Ioana-Ciornei/dpaa2-eth-add-rx-copybreak-support/20210402-022225 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 040806343bb4ef6365166eae666ced8a91b95321 config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0550b91894796909d20b7cfdcd4a751a49d708a3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ioana-Ciornei/dpaa2-eth-add-rx-copybreak-support/20210402-022225 git checkout 0550b91894796909d20b7cfdcd4a751a49d708a3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:421:17: warning: no >> previous prototype for 'dpaa2_eth_copybreak' [-Wmissing-prototypes] 421 | struct sk_buff *dpaa2_eth_copybreak(struct dpaa2_eth_channel *ch, | ^~~~~~~~~~~~~~~~~~~ vim +/dpaa2_eth_copybreak +421 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c 420 > 421 struct sk_buff *dpaa2_eth_copybreak(struct dpaa2_eth_channel *ch, 422 const struct dpaa2_fd *fd, void *fd_vaddr) 423 { 424 u16 fd_offset = dpaa2_fd_get_offset(fd); 425 u32 fd_length = dpaa2_fd_get_len(fd); 426 struct sk_buff *skb = NULL; 427 unsigned int skb_len; 428 429 if (fd_length > DPAA2_ETH_DEFAULT_COPYBREAK) 430 return NULL; 431 432 skb_len = fd_length + dpaa2_eth_needed_headroom(NULL); 433 434 skb = napi_alloc_skb(&ch->napi, skb_len); 435 if (!skb) 436 return NULL; 437 438 skb_reserve(skb, dpaa2_eth_needed_headroom(NULL)); 439 skb_put(skb, fd_length); 440 441 memcpy(skb->data, fd_vaddr + fd_offset, fd_length); 442 443 dpaa2_eth_recycle_buf(ch->priv, ch, dpaa2_fd_get_addr(fd)); 444 445 return skb; 446 } 447 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip