On 3/18/2021 1:01 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <ra...@milecki.pl>
>
> Simple macro like REG_RGMII_CNTRL_P() is insufficient as:
> 1. It doesn't validate port argument
> 2. It doesn't support chipsets with non-lineral RGMII regs layout
>
> Missing port validation could result in getting register offset from out
> of array. Random memory -> random offset -> random reads/writes. It
> affected e.g. BCM4908 for REG_RGMII_CNTRL_P(7).
>
> Fixes: a78e86ed586d ("net: dsa: bcm_sf2: Prepare for different register
> layouts")
> Signed-off-by: Rafał Miłecki <ra...@milecki.pl>
Acked-by: Florian Fainelli <f.faine...@gmail.com>
--
Florian
