On Tue, Mar 09, 2021 at 04:22:44PM +0800, kernel test robot wrote: > Hi Hangbin, > > Thank you for the patch! Yet something to improve:
Thanks, I forgot to modify it when rename the flag name. Hangbin > > [auto build test ERROR on bpf-next/master] > > url: > https://github.com/0day-ci/linux/commits/Hangbin-Liu/xdp-extend-xdp_redirect_map-with-broadcast-support/20210309-153218 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git > master > config: s390-randconfig-s031-20210309 (attached as .config) > compiler: s390-linux-gcc (GCC) 9.3.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-262-g5e674421-dirty > # > https://github.com/0day-ci/linux/commit/d0e1734db001fb56c1428e92145c7f3a001402f3 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review > Hangbin-Liu/xdp-extend-xdp_redirect_map-with-broadcast-support/20210309-153218 > git checkout d0e1734db001fb56c1428e92145c7f3a001402f3 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 > CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <l...@intel.com> > > All errors (new ones prefixed by >>): > > net/core/filter.c: In function '__bpf_tx_xdp_map': > >> net/core/filter.c:3928:15: error: 'BPF_F_REDIR_BROADCAST' undeclared > >> (first use in this function); did you mean 'BPF_F_BROADCAST'? > 3928 | if (flags & BPF_F_REDIR_BROADCAST) > | ^~~~~~~~~~~~~~~~~~~~~ > | BPF_F_BROADCAST > net/core/filter.c:3928:15: note: each undeclared identifier is reported > only once for each function it appears in > >> net/core/filter.c:3930:20: error: 'BPF_F_REDIR_EXCLUDE_INGRESS' undeclared > >> (first use in this function); did you mean 'BPF_F_EXCLUDE_INGRESS'? > 3930 | flags & BPF_F_REDIR_EXCLUDE_INGRESS); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > | BPF_F_EXCLUDE_INGRESS > net/core/filter.c: In function 'xdp_do_generic_redirect_map': > net/core/filter.c:4090:19: error: 'BPF_F_REDIR_BROADCAST' undeclared > (first use in this function); did you mean 'BPF_F_BROADCAST'? > 4090 | if (ri->flags & BPF_F_REDIR_BROADCAST) > | ^~~~~~~~~~~~~~~~~~~~~ > | BPF_F_BROADCAST > net/core/filter.c:4092:24: error: 'BPF_F_REDIR_EXCLUDE_INGRESS' undeclared > (first use in this function); did you mean 'BPF_F_EXCLUDE_INGRESS'? > 4092 | ri->flags & BPF_F_REDIR_EXCLUDE_INGRESS); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > | BPF_F_EXCLUDE_INGRESS > net/core/filter.c: In function '____bpf_xdp_redirect_map': > net/core/filter.c:4182:44: error: 'BPF_F_REDIR_BROADCAST' undeclared > (first use in this function); did you mean 'BPF_F_BROADCAST'? > 4182 | if (unlikely(!ri->tgt_value) && !(flags & BPF_F_REDIR_BROADCAST)) > { > | ^~~~~~~~~~~~~~~~~~~~~ > | BPF_F_BROADCAST > > > vim +3928 net/core/filter.c > > 3920 > 3921 static int __bpf_tx_xdp_map(struct net_device *dev_rx, void > *fwd, > 3922 struct bpf_map *map, struct > xdp_buff *xdp, > 3923 u32 flags) > 3924 { > 3925 switch (map->map_type) { > 3926 case BPF_MAP_TYPE_DEVMAP: > 3927 case BPF_MAP_TYPE_DEVMAP_HASH: > > 3928 if (flags & BPF_F_REDIR_BROADCAST) > 3929 return dev_map_enqueue_multi(xdp, > dev_rx, map, > > 3930 flags & > > BPF_F_REDIR_EXCLUDE_INGRESS); > 3931 else > 3932 return dev_map_enqueue(fwd, xdp, > dev_rx); > 3933 case BPF_MAP_TYPE_CPUMAP: > 3934 return cpu_map_enqueue(fwd, xdp, dev_rx); > 3935 case BPF_MAP_TYPE_XSKMAP: > 3936 return __xsk_map_redirect(fwd, xdp); > 3937 default: > 3938 return -EBADRQC; > 3939 } > 3940 return 0; > 3941 } > 3942 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
