On Fri, Feb 26, 2021 at 7:40 PM Jason A. Donenfeld <ja...@zx2c4.com> wrote:
>
> There were a few remaining tunnel drivers that didn't receive the prior
> conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to
> memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from
> icmp{,v6}_ndo_send before sending") for details), there's even more
> imperative to have these all converted. So this commit goes through the
> remaining cases that I could find and does a boring translation to the
> ndo variety.
>
> The Fixes: line below is the merge that originally added icmp{,v6}_
> ndo_send and converted the first batch of icmp{,v6}_send users. The
> rationale then for the change applies equally to this patch. It's just
> that these drivers were left out of the initial conversion because these
> network devices are hiding in net/ rather than in drivers/net/.
>
> Cc: Florian Westphal <f...@strlen.de>
> Cc: Willem de Bruijn <will...@google.com>
> Cc: David S. Miller <da...@davemloft.net>
> Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org>
> Cc: David Ahern <dsah...@kernel.org>
> Cc: Jakub Kicinski <k...@kernel.org>
> Cc: Steffen Klassert <steffen.klass...@secunet.com>
> Fixes: 803381f9f117 ("Merge branch
> 'icmp-account-for-NAT-when-sending-icmps-from-ndo-layer'")
> Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com>
Acked-by: Willem de Bruijn <will...@google.com>
