> @@ -248,9 +296,15 @@ static int stmmac_mdio_write(struct mii_bus *bus, int > phyaddr, int phyreg, > unsigned int mii_address = priv->hw->mii.addr; > unsigned int mii_data = priv->hw->mii.data; > u32 value = MII_BUSY; > - int data = phydata; > + int ret, data = phydata; > u32 v;
Reverse Christmass tree. Otherwise this looks good. Andrew