Hi "Uwe, I love your patch! Yet something to improve:
[auto build test ERROR on next-20210224] [also build test ERROR on v5.11] [cannot apply to powerpc/next sparc/master sparc-next/master v5.11 v5.11-rc7 v5.11-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/vio-make-remove-callback-return-void/20210224-153029 base: 577c283560fe8a81a23a95654c6d13e8412d22f1 config: powerpc-randconfig-r013-20210223 (attached as .config) compiler: powerpc64le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1cc965e9b41d0acfaf8d597ffeb7ef1c2031ec4c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Uwe-Kleine-K-nig/vio-make-remove-callback-return-void/20210224-153029 git checkout 1cc965e9b41d0acfaf8d597ffeb7ef1c2031ec4c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/tty/hvc/hvcs.c:822:13: error: conflicting types for 'hvcs_remove' 822 | static void hvcs_remove(struct vio_dev *dev) | ^~~~~~~~~~~ drivers/tty/hvc/hvcs.c:320:12: note: previous declaration of 'hvcs_remove' was here 320 | static int hvcs_remove(struct vio_dev *dev); | ^~~~~~~~~~~ vim +/hvcs_remove +822 drivers/tty/hvc/hvcs.c 821 > 822 static void hvcs_remove(struct vio_dev *dev) 823 { 824 struct hvcs_struct *hvcsd = dev_get_drvdata(&dev->dev); 825 unsigned long flags; 826 struct tty_struct *tty; 827 828 /* By this time the vty-server won't be getting any more interrupts */ 829 830 spin_lock_irqsave(&hvcsd->lock, flags); 831 832 tty = hvcsd->port.tty; 833 834 spin_unlock_irqrestore(&hvcsd->lock, flags); 835 836 /* 837 * Let the last holder of this object cause it to be removed, which 838 * would probably be tty_hangup below. 839 */ 840 tty_port_put(&hvcsd->port); 841 842 /* 843 * The hangup is a scheduled function which will auto chain call 844 * hvcs_hangup. The tty should always be valid at this time unless a 845 * simultaneous tty close already cleaned up the hvcs_struct. 846 */ 847 if (tty) 848 tty_hangup(tty); 849 850 printk(KERN_INFO "HVCS: vty-server@%X removed from the" 851 " vio bus.\n", dev->unit_address); 852 }; 853 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
