On Tue, 23 Feb 2021 17:02:06 -0800 Jakub Kicinski wrote: > On Wed, 24 Feb 2021 01:32:51 +0100 Michal Kubecek wrote: > > On Tue, Feb 23, 2021 at 02:24:40PM +0100, Simon Horman wrote: > > > From: Yinjun Zhang <[email protected]> > > > > > > The command "ethtool -L <intf> combined 0" may clean the RX/TX channel > > > count and skip the error path, since the attrs > > > tb[ETHTOOL_A_CHANNELS_RX_COUNT] and tb[ETHTOOL_A_CHANNELS_TX_COUNT] > > > are NULL in this case when recent ethtool is used. > > > > > > Tested using ethtool v5.10. > > > > > > Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for > > > TX/RX in the core") > > > Signed-off-by: Yinjun Zhang <[email protected]> > > > Signed-off-by: Simon Horman <[email protected]> > > > Signed-off-by: Louis Peens <[email protected]> > > > > Reviewed-by: Michal Kubecek <[email protected]> > > IOW you prefer this to what I proposed?
Hah, now I missed your email :)
