Re: [PATCH] net: stmmac: Fix missing spin_lock_init in visconti_eth_dwmac_probe()

[Nobuhiro Iwamatsu]

Hi,

On Tue, Feb 23, 2021 at 10:48:03AM +0000, Wei Yongjun wrote:
> The driver allocates the spinlock but not initialize it.
> Use spin_lock_init() on it to initialize it correctly.
> 
> Fixes: b38dd98ff8d0 ("net: stmmac: Add Toshiba Visconti SoCs glue driver")
> Reported-by: Hulk Robot <hul...@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>

Thanks for your fix.

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwama...@toshiba.co.jp>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c 
> b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> index b7a0c57dfbfb..d23be45a64e5 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> @@ -218,6 +218,7 @@ static int visconti_eth_dwmac_probe(struct 
> platform_device *pdev)
>               goto remove_config;
>       }
>  
> +     spin_lock_init(&dwmac->lock);
>       dwmac->reg = stmmac_res.addr;
>       plat_dat->bsp_priv = dwmac;
>       plat_dat->fix_mac_speed = visconti_eth_fix_mac_speed;
> 
>

Best regards,
  Nobuhiro