> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: 2021年2月23日 3:48 > To: Joakim Zhang <qiangqing.zh...@nxp.com> > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac > resume back > > On Sat, 20 Feb 2021 07:52:46 +0000 Joakim Zhang wrote: > > > I'm not sure why you recycle and reallocate every buffer. Isn't it > > > enough to reinitialize the descriptors with the buffers which are already > allocated? > > > > As I know, the receive buffer address is not fixed after allocated, it > > will recycle and re-allocate in stmmac_rx(), where to handle the > > receive buffers. > > Not sure what you mean by that. The driver must know the addresses of the > memory it allocated and handed over to the device.
What I mean is that, in stmmac driver, it creates a page pool for rx patch, it will always recycle and re-allocate pages to fill descriptors' dma address. Best Regards, Joakim Zhang > > It should be enough to re-initialize the descriptors with the buffers > > if it is possible. Could you point me how to do it?
