On Wed, Feb 17, 2021 at 1:25 PM Vladimir Oltean <olte...@gmail.com> wrote:

> I'm not going to do a detailed review on a driver that is a 90% copy of
> rtl8366rb. You should probably spend some time to avoid duplicating
> what is common.

The split of common and individual code comes from the OpenWrt
driver, maybe it wasn't optimal. Maybe we can move some of the
driver into the shared rtl8366.c file.

Yours,
Linus Walleij

Reply via email to