On Wed, Feb 17, 2021 at 09:17:59AM +0300, Dan Carpenter wrote:
> Smatch warns that there is a locking issue in this function:
>
> drivers/net/phy/icplus.c:273 ip101a_g_config_intr_pin()
> warn: inconsistent returns '&phydev->mdio.bus->mdio_lock'.
> Locked on : 242
> Unlocked on: 273
>
> It turns out that the comments in phy_select_page() say we have to call
> phy_restore_page() even if the call to phy_select_page() fails.
>
> Fixes: f9bc51e6cce2 ("net: phy: icplus: fix paged register access")
Don't apply this patch. I have created a new Smatch warning for the
phy_select_page() behavior and it catches a couple similar bugs in the
same file. I will send a v2 that fixes those as well.
regards,
dan carpenter
