On 13/02/2021 22:43, Vladimir Oltean wrote: > From: Vladimir Oltean <vladimir.olt...@nxp.com> > > The bridge sysfs interface stores parameters for the STP, VLAN, > multicast etc subsystems using a predefined function prototype. > Sometimes the underlying function being called supports a netlink > extended ack message, and we ignore it. > > Let's expand the store_bridge_parm function prototype to include the > extack, and just print it to console, but at least propagate it where > applicable. Where not applicable, create a shim function in the > br_sysfs_br.c file that discards the extra function argument. > > This patch allows us to propagate the extack argument to > br_vlan_set_default_pvid, br_vlan_set_proto and br_vlan_filter_toggle, > and from there, further up in br_changelink from br_netlink.c. > > Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com> > --- > net/bridge/br_netlink.c | 2 +- > net/bridge/br_private.h | 9 ++- > net/bridge/br_sysfs_br.c | 166 ++++++++++++++++++++++++++++++--------- > net/bridge/br_vlan.c | 11 ++- > 4 files changed, 142 insertions(+), 46 deletions(-) >
Hi, You have to update the !CONFIG_BRIDGE_VLAN_FILTERING br_vlan_filter_toggle stub as well otherwise compilation will fail. Thanks, Nik
