On 2/12/2021 5:14 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: >> That's right, tg3 drove a lot of the Broadcom PHY driver changes back >> then, I also would like to rework the way we pass flags towards PHY >> drivers because tg3 is basically the only driver doing it right, where >> it checks the PHY ID first, then sets appropriate flags during connect. > > Why does the tg3 controller need to enable the auto power down PHY > feature in the first place and the PHY driver can't just enable it by > itself? > That would be a question for Michael if he remembers those details from 12 years ago. -- Florian
- [PATCH net-next 0/3] net: phy: broadcom: APD improvements Florian Fainelli
- [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC... Florian Fainelli
- Re: [PATCH net-next 2/3] net: phy: broadcom: Fix... Vladimir Oltean
- Re: [PATCH net-next 2/3] net: phy: broadcom:... Florian Fainelli
- Re: [PATCH net-next 2/3] net: phy: broad... Florian Fainelli
- [PATCH net-next 3/3] net: phy: broadcom: Allow BCM54... Florian Fainelli
- [PATCH net-next 1/3] net: phy: broadcom: Remove unus... Florian Fainelli
- Re: [PATCH net-next 1/3] net: phy: broadcom: Rem... Vladimir Oltean
- Re: [PATCH net-next 1/3] net: phy: broadcom:... Florian Fainelli
- Re: [PATCH net-next 1/3] net: phy: broad... Vladimir Oltean
- Re: [PATCH net-next 1/3] net: phy: ... Florian Fainelli
- Re: [PATCH net-next 0/3] net: phy: broadcom: APD imp... Andrew Lunn